[FAILING TESTS] lines with trailing spaces#12
Open
soenkehahn wants to merge 1 commit intoindentjs:masterfrom
Open
[FAILING TESTS] lines with trailing spaces#12soenkehahn wants to merge 1 commit intoindentjs:masterfrom
soenkehahn wants to merge 1 commit intoindentjs:masterfrom
Conversation
rattrayalex
reviewed
Aug 1, 2022
| foo | ||
| ${insertion} | ||
| `; | ||
| expect(output).toEqual("foo\n indented 1\n\n indented 2"); |
There was a problem hiding this comment.
For clarity, current behavior is
"foo\n indented 1\n \n indented 2"
(note the extra two spaces between the newlines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this PR instead of opening an issue, because I thought it would be easier to describe and understand. So this is not a PR submitted for merging, but a bug report.
When
endentencounters spliced in text that is indented relative to other text in the template string, it inserts indentation on any newlines that appear in the spliced in text. (Which is great!) However when the spliced in text contains two (or more) consecutive newline characters, this means that the text thatendentyields contains lines that contain only spaces. As far as I can tell, this is (almost?) never the desired behavior. So I thinkendentshould not insert indentation spaces on empty lines.